Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ALB addon pods should include CriticalAddonsOnly op=Exists toleration #4598

Open
ivanthelad opened this issue Oct 23, 2024 · 2 comments
Assignees
Labels
AGC Application Gateway for Containers bug

Comments

@ivanthelad
Copy link

ivanthelad commented Oct 23, 2024

Describe the bug
The Gateway for containers controller does not tolerate the system-node pools. It should include the toleration. currently it include the default tolerations from the scheduler

  •    node.kubernetes.io/memory-pressure:NoSchedule op=Exists  
    
  •    node.kubernetes.io/not-ready:NoExecute op=Exists for 300s   
    
  •    node.kubernetes.io/unreachable:NoExecute op=Exists for 6000s
    

The ALB controller should include

  •    CriticalAddonsOnly op=Exists
    

To Reproduce
None: Inspect the pod alb-controller under the ns azure-alb-system

Expected behavior
The ALB pods should have a preference for the system node pools. As they currently don't have that toleration they are repelled by the system pools

Environment (please complete the following information):

  • CLI Version 2.65.0
  • Kubernetes version 1.30.4
  • CLI Extension version
    • alb 1.0.0
@ivanthelad ivanthelad added the bug label Oct 23, 2024
@ivanthelad
Copy link
Author

helm upgrade alb-controller oci://mcr.microsoft.com/application-lb/charts/alb-controller --post-renderer yq --post-renderer-args 'select(.kind=="Deployment") |= .spec.template.spec.tolerations += [{"key": "CriticalAddonsOnly", "operator": "Exists"}]'

as a workaround to modify ALB controller generated by helm

@PixelRobots PixelRobots added the AGC Application Gateway for Containers label Oct 24, 2024
Copy link
Contributor

@JackStromberg would you be able to assist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AGC Application Gateway for Containers bug
Projects
None yet
Development

No branches or pull requests

3 participants