Update CheckSignature.ps1 to output checked assemblies and results to a file #27175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a file Update `tools/CheckSignature.ps1` to output checked assemblies and their validation results to a file. * Add a new parameter `OutputFilePath` to specify the output file path. * Modify `Check-StrongName` function to log the checked assemblies and their validation results to the specified output file. * Modify `Check-AuthenticodeSignature` function to log the checked assemblies and their validation results to the specified output file. * Continue to output the results of the signature checks to the console as before. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Azure/azure-powershell?shareId=XXXX-XXXX-XXXX-XXXX).
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
NoriZC
reviewed
Feb 20, 2025
| ) | ||
|
|
||
| function Check-StrongName { | ||
| [CmdletBinding()] | ||
| param([Parameter(ValueFromPipeline=$true)][string]$path) | ||
| Write-Output "Checking strong name for $path" | Out-File -Append $OutputFilePath |
There was a problem hiding this comment.
Do we need a parameter validation to ensure that the OutputFilePath is valid and writable.
There was a problem hiding this comment.
It's worth checking.
I'll implement it in another PR
|
Continued in #27205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
tools/CheckSignature.ps1to output checked assemblies and their validation results to a file.OutputFilePathto specify the output file path.Check-StrongNamefunction to log the checked assemblies and their validation results to the specified output file.Check-AuthenticodeSignaturefunction to log the checked assemblies and their validation results to the specified output file.For more details, open the Copilot Workspace session.