Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json - parameterValues should be of type object and not type string #31682

Open
mbfrahry opened this issue Nov 27, 2024 · 1 comment
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@mbfrahry
Copy link
Contributor

API Spec link

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json#L1877

API Spec version

2016-06-01

Describe the bug

We're seeing a bug when trying to ingest parameterValues, customParameterValues, and nonSecretParameterValues into a go sdk. This issue is stemming from the additionalProperties type being string when it really should be object.

For example, the api accepts the following request even though 22 is not a string.

"parameterValues": {
	"portNumber": 22
}

Expected behavior

I expect that

"parameterValues": {
  "description": "Dictionary of parameter values",
  "type": "object",
  "additionalProperties": {
    "type": "string"
  }
},

should instead be

"parameterValues": {
  "description": "Dictionary of parameter values",
  "type": "object",
  "additionalProperties": {
    "type": "object"
  }
},

for parameterValues, customParameterValues, and nonSecretParameterValues.

Actual behavior

We're seeing the api accept a number and not a string which is causing our go-sdk to throw errors because we're expecting type string but the api is giving type object.

Reproduction Steps

This request can be PUT to https://management.azure.com/subscriptions/XXXXXX/resourceGroups/acctestRG-conn-matthew/providers/Microsoft.Web/connections/sftpwithssh?api-version=2016-06-01

{
	"location": "westus",
	"properties": {
		"api": {
			"id": "/subscriptions/XXXXX/providers/Microsoft.Web/locations/westus/managedApis/sftpwithssh"
		},
		"displayName": "test",
		"parameterValues": {
			"portNumber": 22
		}
	},
	"tags": {}
}

and we'll see that the api accepts other types and not just strings

Environment

No response

@mbfrahry mbfrahry added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Nov 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added question The issue doesn't require a change to the product in order to be resolved. Most issues start as that customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Nov 27, 2024
@v-jiaodi v-jiaodi added the Mgmt This issue is related to a management-plane library. label Nov 27, 2024
@v-jiaodi
Copy link
Member

@refortie Please help take a look, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

3 participants