Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage new project scaffolding for management-plane new service onboarding #46898

Open
live1206 opened this issue Oct 30, 2024 · 1 comment
Open

Leverage new project scaffolding for management-plane new service onboarding #46898

live1206 opened this issue Oct 30, 2024 · 1 comment
Assignees
@live1206 @welovej
Labels
EngSys This issue is impacting the engineering system. Mgmt-EngSys Engineering System (Management Plane Specific)

Comments

@live1206
Copy link
Member

For management-plane new service onboarding, we should leverage new project scaffolding instead of template.
To be consistent with the behavior of DPG new service onboarding.

When this is ready, we should update https://eng.ms/docs/products/azure-developer-experience/develop/sdk-generate-mgmt-dotnet accordingly.
@live1206 live1206 added the Mgmt This issue is related to a management-plane library. label Oct 30, 2024
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 30, 2024
@jsquire jsquire added Mgmt-EngSys Engineering System (Management Plane Specific) EngSys This issue is impacting the engineering system. and removed Mgmt This issue is related to a management-plane library. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 30, 2024
@welovej
Copy link
Member

welovej commented Nov 6, 2024

---high priority item

  • xxx.Samples.csproj not generated and not included in .sln
  • assets.json not generated
  • <PackageId>Azure.ResourceManager.xxx</PackageId> not generated in Azure.ResourceManager.xxx.csproj
  • tests/xxxManagementTestBase.cs and /tests/xxxManagementTestEnvironment.cs not generated

--low priority item

  • difference: <Description> xxx.</Description> in Azure.ResourceManager.xxx.csproj
  • difference: <PackageTags>xxxx</PackageTags> in Azure.ResourceManager.xxx.csproj
  • difference: [assembly:Azure.Core.AzureResourceProviderNamespace("Microsoft.Template")] in Azure.ResourceManager.xxx.csproj
  • redundant: <TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks> in Azure.ResourceManager.xxx.csproj
  • redundant: <IncludeOperationsSharedSource>true</IncludeOperationsSharedSource> in Azure.ResourceManager.xxx.csproj
  • redundant: additionalDirectories in tsp-location.yaml
  • redundant:
    $(RequiredTargetFrameworks) $(NoWarn);CS1591
    in Azure.ResourceManager.xxx.Tests.csproj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@live1206 live1206

@welovej welovej

Labels
EngSys This issue is impacting the engineering system. Mgmt-EngSys Engineering System (Management Plane Specific)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsquire @live1206 @welovej