Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding videos in mindLAMP #867

Open
kijote0 opened this issue Nov 27, 2024 · 8 comments
Open

Embedding videos in mindLAMP #867

kijote0 opened this issue Nov 27, 2024 · 8 comments
Assignees
Labels
feature New feature or request QA testing Issue is being QA tested for production release

Comments

@kijote0
Copy link
Contributor

kijote0 commented Nov 27, 2024

We would like to be able to play videos directly from within the mindLAMP app, rather than using hyperlinks. We will add more details on this soon.

@kijote0 kijote0 added the feature New feature or request label Nov 27, 2024
@sarithapillai8
Copy link
Contributor

@kijote0 Just to confirm, are you asking if the video from the tip activity should be played directly when provided as a URL, rather than displaying it as a hyperlink in the tip activity, or if it should be embedded as part of the tip content, similar to how videos are embedded in this comment section?

@kijote0
Copy link
Contributor Author

kijote0 commented Dec 2, 2024

@sarithapillai8 The videos should be embedded as part of the tip content: similar to how videos are embedded in GitHub comments, users should be able to open the video in full screen mode, for instance.

@sarithapillai8
Copy link
Contributor

Ok Got it @kijote0

@sarithapillai8 sarithapillai8 added the QA testing Issue is being QA tested for production release label Dec 11, 2024
@evinkalengaden
Copy link

Hi @kijote0

We have updated the changes in ZCODEMO https://lamp-dashboard.zcodemo.com/#/, Let me know your comments.

Thanks,
Evin K Alengaden

@kijote0
Copy link
Contributor Author

kijote0 commented Jan 15, 2025

Hi @evinkalengaden, just wanted to confirm: to test the video embedding, should I just create a Tip and format a hyperlink in Markdown like normal? I tried do that, and the video did not seem to load properly:

Image

@evinkalengaden
Copy link

Hi @kijote0

Thankyou for the feedback.
You can give the video link in the Tip description box as I specified the sample format in the attached image, to access in the Tip video. Let me know your comments.

Image

Thanks,
Evin K Alengaden

@kijote0
Copy link
Contributor Author

kijote0 commented Jan 17, 2025

@evinkalengaden I tried that, and it did not seem to work. This is how I configured the tip:

Image

However, I tried using iframe instead, and that seems to work:

Image

Image

To embed videos, should we just write an html block with iframe instead? Probably it would be convenient to have the format you provided also work since it would be simpler.

I tried writing an html block with iframe on the production dashboard, but it does not render properly:

Image

Would it be possible for this to be fixed?

@evinkalengaden
Copy link

Hi @kijote0

While we were analyzing the link you mentioned, found it was wrong, As you have updated the video link from the Share link. The video link specified from the Share link will not work.
We have to specify the link displayed on the browsers URL's which I have given a note (Screenshot 1) and marked using the red arrow in the attached screenshot. Try this way and let me know your comments.

Image

I have mentioned the sample video link using the same video URL (Screen shot 2)

Image

Thanks,
Evin K Alengaden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request QA testing Issue is being QA tested for production release
Projects
None yet
Development

No branches or pull requests

4 participants