Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watch-container-size prop #12

Closed
1 task done
weotch opened this issue Dec 6, 2016 · 1 comment
Closed
1 task done

Add watch-container-size prop #12

weotch opened this issue Dec 6, 2016 · 1 comment

Comments

@weotch
Copy link
Member

weotch commented Dec 6, 2016

When true, keeps the container size variables up to date even if there is no video.

In addition, if there is an object image config, the container size will be used for determining which image to show, not the window. Thus, if an image takes only 50% of the width, this will use a smaller image than it normally would.

  • Do a JS perf to see if reading only one dimension is faster.
@weotch
Copy link
Member Author

weotch commented Dec 6, 2016

Reading only one axis takes half the work, so I should only update the width when doing this: https://jsperf.com/does-reading-one-offset-improve-performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant