Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in-viewport status continues to be updated after images load #13

Closed
weotch opened this issue Dec 7, 2016 · 0 comments
Closed

in-viewport status continues to be updated after images load #13

weotch opened this issue Dec 7, 2016 · 0 comments
Labels
bug

Comments

@weotch
Copy link
Member

weotch commented Dec 7, 2016

After all images have loaded (from a visible load config) when there is no video, scrollMonitor can be destroyed. Additionally, I think I should get rid of setting that in-viewport class, it won't be updated anymore so isn't needed.
@weotch weotch added the bug label Dec 7, 2016
weotch added a commit that referenced this issue Aug 29, 2017
@weotch
Remove in-viewport classes
d2d7db1 
They can’t be depended on since we remove listeners after load
#13
@weotch weotch closed this as completed in 6484147 Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weotch