Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for playsinline attribute #16

Closed
thelucre opened this issue May 17, 2018 · 7 comments
Closed

Add support for playsinline attribute #16

thelucre opened this issue May 17, 2018 · 7 comments
Assignees

Comments

@thelucre
Copy link
Contributor

Info: https://webkit.org/blog/6784/new-video-policies-for-ios/

Either explicitly support the playsinline attribute as a prop or future proof by setting an attribute object as a config with boolean values, like :attributes="{ playsinline: true, loop: false }"

@weotch
Copy link
Member

weotch commented May 17, 2018

Oh wow, interesting!

@thelucre
Copy link
Contributor Author

Yeah! Also, this polyfill might be useful as well: https://github.com/bfred-it/iphone-inline-video

@weotch
Copy link
Member

weotch commented May 30, 2018

I think I am gonna use that polyfill, looks pretty legit.

@weotch
Copy link
Member

weotch commented May 30, 2018

I'm going to apply playsinline by default, that's in the spirit of what vue-visual is for. Note, I found in Android you'll also need to explicitly set muted. IOS doesn't seem to require that.

@weotch weotch self-assigned this May 30, 2018
@thelucre
Copy link
Contributor Author

thelucre commented May 30, 2018

Great! I've seen desktop and mobile Safari throw an error when muted is missing, as well.

@weotch
Copy link
Member

weotch commented May 30, 2018

Hmmm, that polyfill wasn't working for me via browserstack. Just gonna implement the native playsinline attribute. I think that's fine...

statcounter-ios_version-us-monthly-201704-201804

weotch added a commit that referenced this issue May 30, 2018
@weotch
Copy link
Member

weotch commented May 30, 2018

Ok, released as 0.5.0, lemme know how that goes!

@weotch weotch closed this as completed May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants