Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max-width:100% to .vv-slot to prevent line wrapping when .vv-slot contents #30

Closed
jonjahr opened this issue Jun 11, 2020 · 2 comments
Closed

Add max-width:100% to .vv-slot to prevent line wrapping when .vv-slot contents #30

jonjahr opened this issue Jun 11, 2020 · 2 comments

Comments

@jonjahr
Copy link
Contributor

jonjahr commented Jun 11, 2020

vue-visual/index.vue

Line 149 in 09f3f8b

.vv-slot

When contents of .vv-slot are wider than viewport, .vv-slot wraps below .vv-aspect-shim. Recommend adding max-width:100% to .vv-slot. I know the consumer can solve this by styling their own content's width, but this addition would make things more foolproof.

See GIF of behavior:
https://i.imgur.com/xTqPZQk.gif
@weotch weotch closed this as completed in 1d0a047 Jun 11, 2020
@weotch
Copy link
Member

weotch commented Jun 11, 2020

Huh, surprised I hadn't run into that before. Thanks! The video was very useful.

@weotch
Copy link
Member

weotch commented Jun 11, 2020

Released as 2.0.5 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weotch @jonjahr