Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a slot align-strategy prop #5

Closed
weotch opened this issue Dec 1, 2016 · 2 comments
Closed

Add a slot align-strategy prop #5

weotch opened this issue Dec 1, 2016 · 2 comments

Comments

@weotch
Copy link
Member

weotch commented Dec 1, 2016

  • vertical-align - The default
  • absolute - The transform apporach
  • table - Does display:table and display:table-cell on slot, useful when you want to use a min-height height on the visual.
@weotch
Copy link
Member Author

weotch commented Dec 13, 2016

I updated the above, min-height on tables doesn't work in Firefox.

Also, if .vv-visual is set to a table, the overflow:hidden doesn't apply to the .vv-video in Firefox. The overflow should be moved inside, perhaps to the transition that wraps the video. That kinda makes sense since the overflow is only REQUIRED for the video.

@weotch
Copy link
Member Author

weotch commented Mar 29, 2020

Don't remember why this was necessary ... I don't think it will be now.

@weotch weotch closed this as completed Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant