Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching image breakpoints when there is a video showing should not be visible #8

Closed
weotch opened this issue Dec 3, 2016 · 5 comments
Labels

Comments

@weotch
Copy link
Member

weotch commented Dec 3, 2016

Right now there is a flash when switching between breakpoints, even when a video is up. I think this is because the image unloading makes the video v-show toggle because it is dependend on it's predecessor being loaded.

Perhaps the refactoring of render in #1 will fix this.

@weotch weotch added the bug label Dec 3, 2016
@weotch
Copy link
Member Author

weotch commented Dec 3, 2016

@weotch
Copy link
Member Author

weotch commented Dec 5, 2016

Two ideas:

  1. Don't destroy the old image until the new one has loaded. This is the simpler idea
  2. Make a child component for images. It is everything that is currently inside the asset transition. Then, use dynamic components to render the child based and the src. Thus, when switching there will be two instances for a time that transition into one another.

@weotch
Copy link
Member Author

weotch commented Dec 5, 2016

Oh, but as this relates to the video, in both cases the image never gets nulled so the video shouldn't disappear.

@weotch
Copy link
Member Author

weotch commented Sep 13, 2018

Don't destroy the old image until the new one has loaded. This is the simpler idea

Not really simple because we're binding the src of the image so it changes immediately, I think we need have an intermediate src value that is only set when the new image is loaded. But I think we could use a :key on the child of the transition to do the transition between the two assets.

In other words, the data that src in the template is bound to is only updated when an image is loaded...

@weotch
Copy link
Member Author

weotch commented Mar 29, 2020

Won't happen in 2.0 and support for srcset

@weotch weotch closed this as completed Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant