Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopting NSIS to build installation package #45

Open
KrasnayaPloshchad opened this issue Dec 28, 2021 · 3 comments
Open

Adopting NSIS to build installation package #45

KrasnayaPloshchad opened this issue Dec 28, 2021 · 3 comments
Labels
distribution distribution or redistribution related issue help wanted Extra attention is needed

Comments

@KrasnayaPloshchad
Copy link

KrasnayaPloshchad commented Dec 28, 2021

With help of NSIS you can easy to configure and build installation package for this on Windows, and the program would be easy to uninstall at Control Panel. The package could gain options to let user choose to install either into Program Files folder or as portable mode, also allows user to add file assosiations.

@BLumia
Copy link
Owner

BLumia commented Dec 28, 2021

Right now we could produce NSIS generated installer by using the KDE Craft build script or CPack NSIS generator, but right now it couldn't do file associations. I'm planning to improve packaging but doesn't have time to work on that right now :)

@BLumia BLumia added distribution distribution or redistribution related issue help wanted Extra attention is needed labels Dec 28, 2021
@KrasnayaPloshchad
Copy link
Author

KrasnayaPloshchad commented Jan 5, 2022

So first of all, you can add file association in Pineapple, which should be call by command parameters. Then you can add some options in installation interface to call them. I’ve used Imagine, IrfanView and GIMP, they’re all having these options during installation, so I suggest you can try it anyway.

@BLumia
Copy link
Owner

BLumia commented Jan 6, 2022

you can add file association in Pineapple, which should be call by command parameters.

Although I can do that, it's not what I'd like to do. Pineapple Pictures is designed to be just an image viewer and nothing beyond that. File association management should be the installer's or package manager's job instead of the main program. Doing such a thing in the installer or a separated program (XnView MP comes with an Associate files with XnViewMP.exe) is okay for me.

Pineapple Pictures is a cross-platform application that also works under Linux/x11 (I use it under KDE), Generally I'd avoid doing platform-specific jobs that are not related to the main purpose of the program in the implementation.

There might be a separate standalone program to help manage file association for Pineapple Pictures, but anyway, for file-association-related issues, we'll track this request in #13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distribution distribution or redistribution related issue help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants