Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code for generating the figures #8

Closed
felixhorger opened this issue Sep 29, 2023 · 4 comments
Closed

Code for generating the figures #8

felixhorger opened this issue Sep 29, 2023 · 4 comments

Comments

@felixhorger
Copy link

Comments on this file:

  • The name of the file says figure 2, but in the code it says figure 3
  • There are absolute paths specific to the author's computer here
  • Pdfs are generated, but then the figs/ folder includes pngs? See this issue
@alexjaffray
Copy link
Collaborator

@felixhorger The generate_fig_2.jl file wasn't supposed to be included in the submission, this was an oversight on my part. However, it is (for better or worse) submitted, and I can address your comments in order:

  • Regarding the figure title and code mismatch, we chose to remove a figure (i.e figure 2 was previously supposed to be figure 3), but I forgot to adjust the figure title in code.
  • I will change the code paths to be a placeholder value
  • The reason pngs are included rather than pdf is a result of how we did the final step of the figure generation. Running the figure generation code yields a single pdf subfigure of Figure 2, which we then combine and finish externally.

Would it be appropriate to exclude this file from the submission? I am happy to keep it in its current form with the amendments to address your 1st and second comment, but could remove it as well.

@felixhorger
Copy link
Author

Hi Alex, keeping it I think is a good idea! If you implement comments 1 & 2 that's good I'd say :)

@alexjaffray
Copy link
Collaborator

Thanks @felixhorger ! Adding it to my TODO list

@alexjaffray
Copy link
Collaborator

Completed in e81f4e4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants