Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Quality - Stormcast Eternals Allegiance selection has inconsistent type #3208

Closed
logisticpeach opened this issue Aug 24, 2023 · 1 comment

Comments

@logisticpeach
Copy link

The data file for the Stormcast Eternals faction has the following entry for the Allegiance selection:

<selectionEntry id="c6a3-2acf-1e46-3896" name="Allegiance" hidden="false" collective="false" import="true" type="unit">

Note the type="unit" here - most other catalogues I've inspected have the more sensible type="upgrade" here. For example, Lumineth Realmlords and Idoneth Deepkin

I would expect all datasets to have a consistent schema and treat concepts in a constant way.

@exaegrum
Copy link
Collaborator

Your expectation is unfortunately nowhere near met - there is currently a fairly large lack of consistency in general in the implementation. I would like to completely redo the system from scratch, but would like to wait until 4e in case we get indexed like 40k. I'll change this one bc it's a 5 sec fix, but in general schema issues that aren't causing problems aren't going to be touched until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants