Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too big resource: fail upfront (Android) #576

Closed
Deleplace opened this issue Feb 6, 2024 · 2 comments
Closed

Too big resource: fail upfront (Android) #576

Deleplace opened this issue Feb 6, 2024 · 2 comments

Comments

@Deleplace
Copy link
Collaborator

Currently: the URLs gen request fails server side, but the user does not know until they have scanned.

Desired: for now, hardcode the resource limit in the app, and fail immediately, without opening camera.

@Deleplace
Copy link
Collaborator Author

Currently: an error message shows up in a Toaster, but the camera doesn't stop, and the app starts misbehaving.

@Deleplace Deleplace added this to the Android 1.1.2401-next milestone Feb 24, 2024
@Deleplace
Copy link
Collaborator Author

Letting the backend dynamically decide what resources to reject is fine in theory, it just happens that it's currently difficult to "abort zxing scanning intent" when handling the backend's error response. Hence, we now hardcode the max resource size in the Android app, and fail upfront without starting a scanning intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant