Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test for Player::copyFrom #229

Open
BarthPaleologue opened this issue Dec 19, 2024 · 2 comments
Open

Write test for Player::copyFrom #229

BarthPaleologue opened this issue Dec 19, 2024 · 2 comments
Assignees
Labels

Comments

@BarthPaleologue
Copy link
Owner

The Player class is brittle for some parts and testing would help catching future bugs.

The most important is to test copyFrom and ensure that it indeeds perform a deep-copy.

By testing this method, adding new fields to Player without updating copyFrom would result in a test failure of the deep-copy.

@vr-varad
Copy link
Contributor

hey @BarthPaleologue I would like to work on this issue would require some more info regarding the issue

@BarthPaleologue
Copy link
Owner Author

Welcome back :) I assigned you to the issue, let me know what you need to know to complete the issue!

Also don't forget about #245 haha as you are 95% there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants