Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulate engine thrust sound by throttle #234

Open
BarthPaleologue opened this issue Jan 6, 2025 · 1 comment
Open

Modulate engine thrust sound by throttle #234

BarthPaleologue opened this issue Jan 6, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BarthPaleologue
Copy link
Owner

BarthPaleologue commented Jan 6, 2025

In Spaceship::L618, use mainEngineThrottle to set the target volume for thrusterSound instead of the current 0/1 logic. Careful: the mainThrottle can also be negative.

@BarthPaleologue BarthPaleologue added enhancement New feature or request good first issue Good for newcomers labels Jan 6, 2025
@BarthPaleologue
Copy link
Owner Author

  • adding a small documention to mainEngineThrottle to indicate its range [-1,1] would also be nice.

@BarthPaleologue BarthPaleologue added this to the 1.9 - Exploration milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant