Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing PasVulkan on Unix (more precisely, I used now Ubuntu 21.10 with NVIDIA GeForce GTX 660).
This PR contains fixes such that sequence
really works out-of-the-box.
Most importantly, the
compileshaders
script was missing for Unix. I see that for Windows, you have a BAT that calls other BATs in subdirectrories, and these BATs in subdirectrories seem to be just adjusted copies of the same code.For Unix, I made
projects/examples/src/assets/shaders/compileshaders
as a single script with bash function, so it will require less maintenance -- no need to list all vert/frag files, you just need to keep up-to-date the list of calls likecompile_dir textoverlay
for each subdirectory that contains some shader files.Here are 2 screenshots with example happily working on my system :)