No files are written to /sys/devices/platform/msi-ec/

[gapspt]

Laptop model

GS66 Stealth 11UE

EC firmware version

16V4EMSV1.115

Description

I've followed the installation steps but no file is created under the directory /sys/devices/platform/msi-ec/.
In fact the directory itself is not created.

Below is all the installation steps and its outputs (tried it several times, so apt will say there's nothing to install)

~/Downloads$ sudo apt install build-essential linux-headers-generic
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
build-essential is already the newest version (12.9ubuntu3).
linux-headers-generic is already the newest version (5.15.0.131.129).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
~/Downloads$ git clone https://github.com/BeardOverflow/msi-ec && cd msi-ec
Cloning into 'msi-ec'...
remote: Enumerating objects: 1170, done.
remote: Counting objects: 100% (575/575), done.
remote: Compressing objects: 100% (214/214), done.
remote: Total 1170 (delta 453), reused 371 (delta 361), pack-reused 595 (from 2)
Receiving objects: 100% (1170/1170), 1.00 MiB | 1.49 MiB/s, done.
Resolving deltas: 100% (688/688), done.
~/Downloads/msi-ec$ which dkms
/usr/sbin/dkms
~/Downloads/msi-ec$ dkms --version
dkms-2.8.7
~/Downloads/msi-ec$ sudo make dkms-install
dkms --version >> /dev/null
mkdir -p /usr/src/msi_ec-0.08
cp /home/gaps/Downloads/msi-ec/dkms.conf /usr/src/msi_ec-0.08
cp /home/gaps/Downloads/msi-ec/Makefile /usr/src/msi_ec-0.08
cp /home/gaps/Downloads/msi-ec/msi-ec.c /usr/src/msi_ec-0.08
cp /home/gaps/Downloads/msi-ec/ec_memory_configuration.h /usr/src/msi_ec-0.08
sed -e "s/@CFLGS@//" \
    -e "s/@VERSION@/0.08/" \
    -i /usr/src/msi_ec-0.08/dkms.conf
dkms add msi_ec/0.08
Creating symlink /var/lib/dkms/msi_ec/0.08/source -> /usr/src/msi_ec-0.08
dkms build msi_ec/0.08

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area...
make -j16 KERNELRELEASE=6.8.0-52-generic TARGET=6.8.0-52-generic CFLAGS_MODULE+=...
Signing module:
 - /var/lib/dkms/msi_ec/0.08/6.8.0-52-generic/x86_64/module/msi-ec.ko
Secure Boot not enabled on this system.
cleaning build area...
dkms install msi_ec/0.08

msi-ec.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.8.0-52-generic/extra/

depmod...
echo msi-ec > /etc/modules-load.d/msi-ec.conf
~/Downloads/msi-ec$ cat /sys/devices/platform/msi-ec/shift_mode
cat: /sys/devices/platform/msi-ec/shift_mode: No such file or directory
~/Downloads/msi-ec$ ls -la /sys/devices/platform/msi-ec
ls: cannot access '/sys/devices/platform/msi-ec': No such file or directory

Did I miss something?

The OS is Zorin OS (which is Ubuntu based)
The laptop model is GS66 Stealth 11UE which is stated as supported.
The EC version as shown in the BIOS: 16V4EMSV1.115

I've also tried running it with elevated privileges, yielding the same exact result.

[glpnk]

Did you reboot after installation?

You sure that version have V in? 16V4EMSV1.115

Supported EC version is 16V4EMS1.114, so you need to add your version to the same config and reinstall.

[gapspt]

Did you reboot after installation?

I did. No changes.
I also tried adding msi-ec to /etc/modules-load.d/modules.conf and rebooting afterwards, but nothing changed.

You sure that version have V in? 16V4EMSV1.115

Yes, I took a picture with my phone and I'm looking at it.

Supported EC version is 16V4EMS1.114, so you need to add your version to the same config and reinstall.

Do you mean downgrading the BIOS? I couldn't find the 114 mentioned in the support table, where can I see that?

[glpnk]

Do you mean downgrading the BIOS? I couldn't find the 114 mentioned in the support table, where can I see that?

No, literally modify 1 string in source file

At least try to load debug mode to get right name

[gapspt]

It seems to have worked. At least the files are there. The screen flickered when logging in, (which it didn't do before) so it might have changed something related to the gpu.
I'll tinker with it and will let you know if everything seems alright (probably tomorrow or so).

Big thank you, specially for the blazingly fast replies ^_^

[glpnk]

Nice, can you tell you your real EC version from driver side? If you had to change version, can you open Pull Request with your update?

Driver do not modify anything, unless you change something in it

[gapspt]

Do you mean this?

~$ cat /sys/devices/platform/msi-ec/fw_version
16V4EMS1.115
~$ cat /sys/devices/platform/msi-ec/fw_release_date 
2022/12/14 14:27:00

It matches what I see in the BIOS.

Regarding opening a PR: I have no clue what are the implications of changing that 114 to 115, so I'm hesitant to do it.
For example, will it still install correctly for those who have the version 114?
In any case I will have to try it out and see if it is really working correctly before opening a PR.

[glpnk]

I think, there are any differences between versions.

If you have Windows, you can review available options in module and app.

You (or one who made BIOS) made typo:

16V4EMS V 1.115
16V4EMS   1.115

[gapspt]

You (or one who made BIOS) made typo:

16V4EMS V 1.115
16V4EMS   1.115

I have made the typo. There is no V in there.

You sure that version have V in? 16V4EMSV1.115

Yes, I took a picture with my phone and I'm looking at it.

I also misread your question, I thought you were asking me if I was sure it was 115 and not 114. So no, there is no V in there, apologies for the confusion :(

[gapspt]

I think, there are any differences between versions.
If you have Windows, you can review available options in module and app.

I think my mistake was I didn't understand this:

Supported EC version is 16V4EMS1.114, so you need to add your version to the same config and reinstall.

What I did was just changing from 114 to 115, so that's why I was afraid that now it wouldn't work for other users.
But what you are saying is to just add a new line with exactly the same but 115, right?

So far it is working well by the way, so I guess I will open the PR, just want to test it for a little longer.

[glpnk]

Okay, I think this update included any changes related to EC interface.

Please share your EC dump for future usage