Phase Holograms

[iRobSch]

Expected behavior

1. The holograms are supposed to display the appropriate colour that is in the phase's name;
2. The holograms are supposed to be disabled when their configuration option is set to false.

Observed/Actual behavior

https://media.discordapp.net/attachments/310623455462686720/1154306762254598234/image.png?width=1440&height=671

Holograms cannot be killed as an entity - furthermore, you can see the colours do not work. It was reported in the Discord that holograms apparently do not yet have colour support because of an issue.

Furthermore, here's a part of the config:

world:
  # Friendly name for this world. Used in admin commands. Must be a single word
  friendly-name: OneBlock
  # Name of the world - if it does not exist then it will be generated.
  # It acts like a prefix for nether and end (e.g. oneblock_world, oneblock_world_nether, oneblock_world_end)
  world-name: oneblock
  # World difficulty setting - PEACEFUL, EASY, NORMAL, HARD
  # Other plugins may override this setting
  difficulty: HARD
  # Display holograms
  holograms: false

Steps/models to reproduce

Disable holograms in config for one issue, advance to a new phase for the other issue.

BentoBox version

[02:51:27 INFO]: Running Invalid (PUFFERFISH) 1.20.1.
[02:51:27 INFO]: BentoBox version: 1.24.1
[02:51:27 INFO]: Database: JSON
[02:51:27 INFO]: Loaded Game Worlds:
[02:51:27 INFO]: oneblock (OneBlock): Overworld, Nether*, The End*
[02:51:27 INFO]: Loaded Addons:
[02:51:27 INFO]: AOneBlock 1.14.2 (ENABLED)

Plugin list

No response

Other

No response

[tastybento]

To set the colors, use the regular Bukkit chat colors, e.g., &b, or &c, etc. Here's an example:

  # Hologram Lines to Display
  # The First (Before Phase 1) Hologram is Located in your Locale.
  holograms:
    0: "&aGood Luck!"
    1: "&bThis shows a &d color"
    2: "&cThis is red"

The text that appears above the magic block is the hologram and if you set holograms: false then they will not show. This is working, but I think you don't want the Phase titles to appear? There is no config to turn those off, but you can set name: "" in the phase file and nothing will show if you wish to do so.

[BONNe]

I think the complain is about Plains (phase title) not being able to be color coded.

[tastybento]

I think the complain is about Plains (phase title) not being able to be color coded.

Aha. Yes. In that case I can work on that. I’ll do some conversion of chat codes. It’s easy to see how the phase title can be confused for the holograms but they are different.