Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency #2

Open
Hedde opened this issue Apr 6, 2014 · 2 comments
Open

Consistency #2

Hedde opened this issue Apr 6, 2014 · 2 comments

Comments

@Hedde
Copy link

Hedde commented Apr 6, 2014

First of, great work! I'd like to suggest a more consistent usage of trailing slashes, currently some views use them and some don't. It might also be nice to add a hook for ordering urls when plugging into certain viewsets, perhaps using Django's SortedDict.

@BertrandBordage
Copy link
Owner

Yes, there is indeed an inconsistency in trailing slashes. What do you suggest? In my opinion, we should only remove the trailing slash of the create view. Since ListView is some kind of directory, I find it relevant to keep the slash.

By the way, do you think we should rename the ListView url name to model_list (instead of model_index)?

With hindsight, I don't think the whole "dict idea" was good. We need something object-oriented, like what has been implemented in django-rest-framework (see https://github.com/tomchristie/django-rest-framework/blob/2.3.13/rest_framework/routers.py#L79). What do you say?

@eyesee1
Copy link

eyesee1 commented Sep 13, 2019

big yes to routers pls, I wonder if it would be possible to use DRF's?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants