Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip_copying also sets skip_upload to true #90

Closed
ascott18 opened this issue Apr 25, 2021 · 1 comment
Closed

skip_copying also sets skip_upload to true #90

ascott18 opened this issue Apr 25, 2021 · 1 comment

Comments

@ascott18
Copy link
Contributor

In my builds, I have a separate step for GH release creation that uses a trimmed version of my manual changelog (similar issue to #71). A while back, I used to be able to run this with options -o -e -c -l to avoid re-fetching externals, re-localizing, re-copying files, and so on. Unfortunately, a change was made to cause option -c (skip_copying) to also turn off uploading entirely: cf2276c#diff-8bc94a3006768345d17c827c0bb5840e6e4daee6de1c2b1ea672f53f162d171dR117

Looking at that commit message, it feels like this change was maybe unintentional? In any case, it would be nice to be able upload a different changelog to the GH release without having to re-build the entire addon.

@nebularg
Copy link
Member

Looking at that commit message, it feels like this change was maybe unintentional?

Who knows, probably slipped in when I was testing stuff and I figured it was fine :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants