Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in (real) build configs? #5

Open
ferdnyc opened this issue Mar 5, 2021 · 2 comments
Open

Check in (real) build configs? #5

ferdnyc opened this issue Mar 5, 2021 · 2 comments

Comments

@ferdnyc
Copy link
Contributor

ferdnyc commented Mar 5, 2021

Hey @parg, on the heels of my picking around in the code (see #2, #4), next time you build the plugin do you think you could commit whatever build configuration / tooling you use into the repo?

The currently-checked-in build.xml is all kinds of crazypants, with references to nonexistent directories and tons of things being expected to live at some path different from where they actually can be found. I had to make a ton of changes just to get a useful compile out of the mess. So, I can't fathom how that could be the actual build script used to generate this thing "for real".

I could submit a PR with my changes, sure, but I figure it makes the most sense for the configuration in the repo to be exactly what's used to generate the official releases.

@parg
Copy link
Contributor

parg commented Mar 5, 2021

haha,

You assume too much my friend! I use Eclipse to build the .jar (rssfeed.jardesc) and then 7-zip up the required files to build the distribution.

build.xml is something from the past and well rotted. Happy to update it if you have something useable...

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Mar 6, 2021

LOL, OK in that case let me polish up my mess a little and I'll open another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants