Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup tests before v3 #139

Closed
5 tasks done
jakobnissen opened this issue Mar 11, 2021 · 2 comments
Closed
5 tasks done

Fixup tests before v3 #139

jakobnissen opened this issue Mar 11, 2021 · 2 comments
Milestone

Comments

@jakobnissen
Copy link
Member

jakobnissen commented Mar 11, 2021

Two things I'd like to improve on

  • Some of my most recent changes here on version 2 have had insufficient testing. Ideally, I'd like to get coverage up near 100% again. This is much more easily achieved AFTER Spring cleanup for v3 #138 , so this might be one of the later issues to address before v3
  • There are way too many tests for BioSequences - nearly 9000 for LongSequence and 26000 for Mers. That's in package with 10k lines! On my (rather fast) laptop, they take 1.5 minutes. Not an eternity, but still a bit of wait. Worse, most of them don't really do anything except burn CI time and spam up the terminal if something goes wrong. I bet at least 75% of these tests could be eliminated if we cut down on test patterns, like
    for len in 1:64, _ in 1:10
        @test kmer_stuff(len, rand_seq(len))
    end

Do we really need 640 distinct tests here? What are the odds that function fails at k=54, and not before?

So, plan of action:

  • Complete Spring cleanup for v3 #138 , removing everything we don't want in this package
  • Complete Remove Kmers #121 , and any other new features to mers or longsequences
  • Aggressively cut down on needless tests for mers and longsequences
  • Add tests back to get near-100% coverage

Using Aqua on Julia exposes a few method ambiguities. In general, BioSequences have an issue with method ambiguities.

@jakobnissen jakobnissen added this to the v3.0.0 milestone Mar 11, 2021
@kescobo
Copy link
Member

kescobo commented Mar 11, 2021

This makes sense to me as well, and is the kind of thing that I and others can productively help with. Once you've got the cleanup done, I can take a stab at (3) and/or (4).

@jakobnissen
Copy link
Member Author

Since broadcasting is going to be delayed to after the v3 release, and #203 is merged, this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants