Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgCMatrix parsed without dim names #54

Open
nuno-agostinho opened this issue Jan 10, 2025 · 0 comments
Open

dgCMatrix parsed without dim names #54

nuno-agostinho opened this issue Jan 10, 2025 · 0 comments

Comments

@nuno-agostinho
Copy link

nuno-agostinho commented Jan 10, 2025

Hi all,

When parsing dgCMatrix objects (and maybe other sparse matrix classes), the Dimnames attribute is missing in the parsed object.

The issue seems to come from the following lines:

names = None
if "dimnames" in robject["attributes"]:
names = _dispatcher(robject["attributes"]["dimnames"], **kwargs)
if names is not None and len(names) > 0:
return MatrixWrapper(mat, names)

As per the CsparseMatrix documentation (superclass of dgCMatrix), the attribute should be called Dimnames (not dimnames).

It would be fantastic if this could be addressed. Thank you for this amazing project! :)

All the best,
Nuno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant