Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wSIR #3570

Open
10 tasks done
shazanfar opened this issue Sep 19, 2024 · 10 comments
Open
10 tasks done

wSIR #3570

shazanfar opened this issue Sep 19, 2024 · 10 comments
Assignees
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place OK

Comments

@shazanfar
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @shazanfar

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: wSIR
Type: Package
Title: Weighted Sliced Inverse Regression (wSIR) for supervised
        dimension reduction of spatial transcriptomics and single cell
        gene expression data
Version: 0.99.0
Authors@R: c(
    person("Max", "Woollard", email = "[email protected]", 
    role = c("aut", "cre", "ctb"),
    comment=c(ORCID="0009-0000-6319-6926")),
    person("Pratibha", "Panwar", role = c("ctb"), 
    comment = c(ORCID = "0000-0002-7437-7084")),
    person("Linh", "Nghiem", role = c("aut","ctb"),
    comment=c(ORCID = "0000-0003-2874-9067")),
    person("Shila", "Ghazanfar", email = "[email protected]", 
    role = c("aut", "ctb"), comment=c(ORCID="0000-0001-7861-6997"))
    )
Description: Weighted Sliced Inverse Regression (wSIR) is a supervised dimension 
    reduction algorithm for spatial transcriptomics gene expression data. For a 
    provided gene expression matrix and dataframe of each cell's spatial 
    coordinates, wSIR creates a low-dimensional representation of the gene 
    expression data that preserves the ability to predict spatial coordinates 
    that was present in the gene expression data. Furthermore, wSIR provides 
    interpretable loadings which allow for projection of new single-cell gene 
    expression data into a low-dimensional space which preserves the spatial 
    information present in the gene expression data.
License: GPL-2
Encoding: UTF-8
URL: https://sydneybiox.github.io/wSIR
BugReports: https://github.com/sydneybiox/wSIR/issues
biocViews: DimensionReduction,
    Software,
    GeneExpression, 
    SingleCell,
    Spatial,
    Transcriptomics,
    Regression
LazyData: false
Roxygen: list(markdown = TRUE)
Depends: R (>= 4.4.0),
Imports: Rfast,
    magrittr,
    ggplot2,
    umap,
    vctrs,
    stringr,
    distances,
    Rcpp (>= 1.0.11),
    doBy,
    BiocParallel,
    rlang,
    methods
Suggests: knitr,
    BiocStyle,
    class
LinkingTo: Rcpp,
    RcppArmadillo
VignetteBuilder: knitr
RoxygenNote: 7.3.2
NeedsCompilation: yes
Packaged: 2024-08-19 05:25:13 UTC; linhnghiem

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Sep 19, 2024
@lshep
Copy link
Contributor

lshep commented Sep 24, 2024

We like to see interoperability with standard Bioconductor class structures; This package should be expanded to also work with SpatialExperiment or SingleCellExperiment Bioconductor class structures.

@lshep lshep added 3e. pending pre-review changes review has indicated blocking concern that needs attention 3d. needs interop Package must explicitly use Bioconductor structures and methods labels Sep 24, 2024
@shazanfar
Copy link
Author

Hi @lshep we have now added interoperability with the SpatialExperiment and SingleCellExperiment via the runwSIR and calculatewSIR functions, also added BiocParallel use in the exploreWSIRParams function. Thanks, Shila

@lshep
Copy link
Contributor

lshep commented Oct 11, 2024

I'm getting the following ERROR when trying to build locally:

R CMD build wSIR 
* checking for file 'wSIR/DESCRIPTION' ... OK
* preparing 'wSIR':
* checking DESCRIPTION meta-information ... OK
* cleaning src
* installing the package to build vignettes
      -----------------------------------
* installing *source* package 'wSIR' ...
** using staged installation
** libs
using C++ compiler: 'g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0'
g++ -std=gnu++17 -I"/home/lorikern/R-Installs/bin/R-4-4-branch/include" -DNDEBUG  -I'/home/lorikern/R-Libraries/R4.4-Bioc3.20/Rcpp/include' -I'/home/lorikern/R-Libraries/R4.4-Bioc3.20/RcppArmadillo/include' -I/usr/local/include    -fpic  -g -O2   -c RcppExports.cpp -o RcppExports.o
g++ -std=gnu++17 -I"/home/lorikern/R-Installs/bin/R-4-4-branch/include" -DNDEBUG  -I'/home/lorikern/R-Libraries/R4.4-Bioc3.20/Rcpp/include' -I'/home/lorikern/R-Libraries/R4.4-Bioc3.20/RcppArmadillo/include' -I/usr/local/include    -fpic  -g -O2   -c matrixmult.cpp -o matrixmult.o
g++ -std=gnu++17 -shared -L/home/lorikern/R-Installs/bin/R-4-4-branch/lib -L/usr/local/lib -o wSIR.so RcppExports.o matrixmult.o -L/home/lorikern/R-Installs/bin/R-4-4-branch/lib -lR
installing to /tmp/RtmpfvydgC/Rinst6b6c471bf667/00LOCK-wSIR/00new/wSIR/libs
** R
** data
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded from temporary location
Error: package or namespace load failed for 'wSIR' in dyn.load(file, DLLpath = DLLpath, ...):
 unable to load shared object '/tmp/RtmpfvydgC/Rinst6b6c471bf667/00LOCK-wSIR/00new/wSIR/libs/wSIR.so':
  /tmp/RtmpfvydgC/Rinst6b6c471bf667/00LOCK-wSIR/00new/wSIR/libs/wSIR.so: undefined symbol: dorgqr_
Error: loading failed
Execution halted
ERROR: loading failed
* removing '/tmp/RtmpfvydgC/Rinst6b6c471bf667/wSIR'
      -----------------------------------
ERROR: package installation failed

@shazanfar
Copy link
Author

Hi @lshep we have made changes that I believe means you should be able to build now, do you mind trying again and letting us know how it goes? Thanks, Shila

@lshep lshep added pre-check passed pre-review performed and ready to be added to git and removed 3e. pending pre-review changes review has indicated blocking concern that needs attention 3d. needs interop Package must explicitly use Bioconductor structures and methods labels Oct 16, 2024
@bioc-issue-bot
Copy link
Collaborator

Your package has been added to git.bioconductor.org to continue the
pre-review process. A build report will be posted shortly. Please
fix any ERROR and WARNING in the build report before a reviewer is
assigned or provide a justification on why you feel the ERROR or
WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting
up remotes to push to git.bioconductor.org. All changes should be
pushed to git.bioconductor.org moving forward. It is required to push a
version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org
access. To manage keys and future access you may want to active your
Bioconductor Git Credentials Account

@bioc-issue-bot bioc-issue-bot added pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean and removed 1. awaiting moderation submitted and waiting clearance to access resources pre-check passed pre-review performed and ready to be added to git labels Oct 16, 2024
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 24.04.1 LTS): wSIR_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/wSIR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: 9091581a743e92c3f91b3e9177911906a710dec7

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings
on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 24.04.1 LTS): wSIR_0.99.3.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/wSIR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot bioc-issue-bot added OK and removed ERROR labels Oct 17, 2024
@lshep lshep added 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place and removed pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean labels Oct 21, 2024
@bioc-issue-bot
Copy link
Collaborator

A reviewer has been assigned to your package for an indepth review.
Please respond accordingly to any further comments from the reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place OK
Projects
None yet
Development

No branches or pull requests

4 participants