add fontawesome css for icons #137
Merged
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiNk-NY
force-pushed
the
fontawesome_icon_includes
branch
from
a8bb695 to
7ba632c
Compare
|
Thanks I hadn't noticed the issue with the titles. If this works for you then I'm okay with the merge. The less manual intervention the better I think |
|
Thanks Lori! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lori, @lshep
The fontawesome icons are not showing on my browser, e.g. the R logo in the title
3.1 Version of Bioconductor andhttps://contributions.bioconductor.org/general.html.I am not sure if that is the case for you as well.
Adding an
includes/header.htmlto the repo and testing locally fixes it for me.One alternative is to use the
fontawesomeR package e.g.,fontawesome::fa("github")but it would require a lot of manual intervention.Let me know if this works for you.
-Marcel