Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employ unified coding style #110

Open
hmoenck opened this issue Sep 29, 2017 · 4 comments
Open

Employ unified coding style #110

hmoenck opened this issue Sep 29, 2017 · 4 comments
Assignees

Comments

@hmoenck
Copy link
Contributor

hmoenck commented Sep 29, 2017

Biotracker is using many different coding styles, mostly because developed by multiple people:

  • Header guards vs. pragma once
  • camel case vs ...
  • members: _ vs m_ vs nothing
  • indentation: spaces vs tabs
  • ...
  • private and public members policy
    Discuss here and employ a good style. Maybe use something like stylecop in VS to do so?
@jutanke
Copy link
Member

jutanke commented Oct 6, 2017

Wasn't there an astyle git-hook already in use? I recall @Sh4kE was working on it like a year ago and at least on his system it seemed to be working.. If I remember correctly it even offered to 'automatically' standardize one's code upon commit/push. If this didn't make it to the workflow yet maybe it makes sense to reach out to Michael and ask him to share his implementation/configs.

@hmoenck
Copy link
Contributor Author

hmoenck commented Oct 6, 2017

I wasn't aware of that. Take a look here: 7d64953 3037cc6 7e0e5ff
Looks like they got skipped in the port to V3.

@hmoenck
Copy link
Contributor Author

hmoenck commented Oct 6, 2017

Look who was a second faster than me :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants