feat(ui): added logout feature #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aksh-Bansal-dev
requested changes
Jul 9, 2022
Samy-33
requested changes
Jul 9, 2022
| import styles from './styles.module.css'; | ||
|
|
||
| export const Sidebar: React.FC<{}> = () => { | ||
| const navigate = useNavigate(); | ||
| const logoutHandler = () => { | ||
| window.sessionStorage.removeItem('token'); |
There was a problem hiding this comment.
Logout is a multi step process. Following should be done in order:
- When user clicks on logout, a
DELETErequest should be sent to the API at/auth/token:revoke - While the request is being processed, the loading should be shown and the whole screen should be disabled.
- Once the request succeeds, remove the token from
sessionStorageand navigate user to/login
| const navigate = useNavigate(); | ||
| const logoutHandler = () => { | ||
| window.sessionStorage.removeItem('token'); | ||
| navigate('/login', {replace: true}); |
There was a problem hiding this comment.
We can omit replace option.
replace: true option replaces the current entry in url history stack with the one we are navigating to. We want current URL to exist in the history.
| // isActive: boolean; | ||
| } | ||
|
|
||
| export const SidebarRow: React.FC<Props> = props => { | ||
| return ( | ||
| <div className={styles.container_row}> | ||
| <div className={styles.container_row} onClick={props.onClick}> |
There was a problem hiding this comment.
This will throw an error when onClick is not provided by the parent.
Something like this should make sure that we don't call onClick when it's null.
<div className={styles.container_row} onClick = {() => props.onClick && props.onClick()}>
|
@prajjwalkapoor, please comment on #128 so that it can be assigned to you. |
|
@prajjwalkapoor, are you still working on this. It has been idle for some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #128