Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Two (different) instances of fetchAndValidateSpec #86

Closed
bh2smith opened this issue Feb 7, 2025 · 1 comment · Fixed by #87
Closed

Bug: Two (different) instances of fetchAndValidateSpec #86

bh2smith opened this issue Feb 7, 2025 · 1 comment · Fixed by #87
Labels
bug Something isn't working

Comments

@bh2smith
Copy link
Collaborator

bh2smith commented Feb 7, 2025

Here is one:

async function fetchAndValidateSpec(url: string): Promise<ValidationResult> {

Here is the second:

//parsing and validation done together to avoid fetching spec twice
export async function validateAndParseOpenApiSpec(
url: string | URL,
): Promise<XMbSpec | undefined> {

To resolve this, we will write unit tests for both, determine which is preferred and delete the other.

@bh2smith bh2smith added the bug Something isn't working label Feb 7, 2025
@bh2smith
Copy link
Collaborator Author

bh2smith commented Feb 7, 2025

So this isn't quite a bug, but we do have two different implementations, not of the parsing, but of the fetching. One of them has a few more [DEV] logs, but they are other wise identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant