Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play alarm sounds randomly. #98

Open
ghost opened this issue Sep 19, 2024 · 5 comments · May be fixed by #126
Open

Play alarm sounds randomly. #98

ghost opened this issue Sep 19, 2024 · 5 comments · May be fixed by #126
Labels
enhancement New feature or request help wanted Not enough knowledge to solve the issue

Comments

@ghost
Copy link

ghost commented Sep 19, 2024

Is your feature request related to a problem? Please describe.
Play alarm sounds randomly.

Describe the solution you'd like
Play alarm sounds randomly.

Use case
I like that the alarm sounds change depending on the day.

Describe alternatives you've considered
It might help you to implement this feature.
github url
https://github.com/mvarendorff/random-alarm
https://github.com/tal3898/random-alarm

Additional context
none.

@ghost ghost added the enhancement New feature or request label Sep 19, 2024
@BlackyHawky BlackyHawky added the help wanted Not enough knowledge to solve the issue label Sep 26, 2024
@Nilsu11
Copy link
Contributor

Nilsu11 commented Oct 11, 2024

@BlackyHawky for this feature to work we need to add storage permissions because a listener for ending songs/ringtones is non-existent in the ringtone class (same goes for any form of playing which requires changing sounds) . Is this reasonable as a tradeoff for this feature?

@BlackyHawky
Copy link
Owner

BlackyHawky commented Oct 12, 2024

@Nilsu11

Is this reasonable as a tradeoff for this feature?

What do you mean? (Sorry to ask, I just want to make sure I understand your question.)

@Nilsu11
Copy link
Contributor

Nilsu11 commented Oct 12, 2024

the tradeoff is the additional storage permission.
So we get the new feature, but also a new permission (for reading music files I think, since the new player would require it). If I (or anyone) were to begin working on the feature, would this permission get in the way of the feature being merged?

@BlackyHawky
Copy link
Owner

I agree that someone could work on this, but I'd like to keep the current ringtone picker interface and not add any other dependencies.

@Nilsu11
Copy link
Contributor

Nilsu11 commented Nov 8, 2024

@BlackyHawky this commit should implement this feature. note that I only included system alarms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Not enough knowledge to solve the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants