Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow k6 scenario to be defined within k6 test #1797

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

asos-benpearson
Copy link

Allow for load scenario to be defined within the K6 script as well as in the Taurus yml file. Currently if no iterations is defined in the Taurus scenario then only 1 iteration is executed before the test ends. This change adds k6 its own get-load method to allow for infinite iterations.

Closes #1791

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (2d005c2) to head (3889e0f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1797      +/-   ##
==========================================
+ Coverage   89.80%   89.82%   +0.02%     
==========================================
  Files          71       71              
  Lines       19587    19621      +34     
==========================================
+ Hits        17588    17622      +34     
  Misses       1999     1999              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asos-benpearson
Copy link
Author

Hi, I have fixed up the tests and improved code coverage. All checks are now passing, thanks.

@asos-benpearson
Copy link
Author

Can someone please review this? Thanks

@asos-benpearson
Copy link
Author

Hi, are any maintainers able to review this PR please?

@aldrichksb
Copy link

Any maintainers able to review this PR please?

Copy link

@asos-gal-onbroner asos-gal-onbroner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes and tested changes in local environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K6 Executor: Scenario defined within K6 .js only executing 1 iteration
4 participants