Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The compass north should always stay red #641

Closed
cbrunnkvist opened this issue Jan 7, 2025 · 3 comments
Closed

The compass north should always stay red #641

cbrunnkvist opened this issue Jan 7, 2025 · 3 comments

Comments

@cbrunnkvist
Copy link

cbrunnkvist commented Jan 7, 2025

The north pointing end of a compass needle is always painted red, and the south may be any shade of white or black. (Ref.)

I guess the relevant change would be in this block

.compass {
svg {
height: 1.8em;
.north {
fill: var(--theme-fg);
}
.south {
fill: var(--theme-fg-light);
}
}
&:active {
svg {
.north {
fill: var(--theme-bg);
}
.south {
fill: var(--theme-bg-light);
}
}
plus adding a (couple) new classes/constants (I am unfamiliar with how you manage colors in this project and Vue).

I was actually finding this to be a bit of a hassle while I using the map to navigate an area and trying to explain to my kids how to use the compass .. I got lost spectating on the map view instead ;-)

@TBlueF
Copy link
Member

TBlueF commented Jan 7, 2025

BlueMap's compass needle is grayscale by design-choice, and i personally don't know if i like how it looks like when it is red.
image

But fortunately you can easily paint your own bluemap's needle-north red by adding a custom-css file like this to your bluemap webroot:

.compass svg .north {
    fill: #ff0000;
}

and registering it in your webapp.conf:

# Here you can add URLs to custom styles (css) so they will be loaded by the webapp
# You can place them somewhere in bluemap's webroot and add the (relative) link here
styles: [
    "assets/my-custom-style.css"
]

If you have another suggestion or want to discuss this further, please do so on our discords #suggestions channel, as GitHub issues are for bug-reports or planned features :)

@TBlueF TBlueF closed this as completed Jan 7, 2025
@cbrunnkvist
Copy link
Author

Oh that seems very doable, I'll just do that then. Thanks for the tip! (And my intention was not to suggest "#F00"-red, I should've written "bright red tone", but yeah...)

Either way, thank you again / and for creating an awesome "just works"-plugin!

@cbrunnkvist
Copy link
Author

For completeness sake I would add that the low/no-contrast issue I had, was primarily not on "dark" but in the regular/light mode:
Screenshot 2025-01-09 at 09 25 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants