Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataArrayProxy converting dimensions from double to size_t from JSON #414

Open
JDuffeyBQ opened this issue Jan 22, 2021 · 0 comments
Open

Comments

@JDuffeyBQ
Copy link
Contributor

In DataArrayProxy::readVector, an array of numbers is read from JSON and converted to a std::vector<size_t>. This function is used to read the tuple and component dimensions from JSON. This function does some checks on the range of acceptable values; however, it does not report any errors and has an implicit conversion between double and size_t inside its check. For exceedingly large datasets this would be an issue when attempting to read and write their dimensions.

A possible solution would be to store the dimensions as a string though this would affect backwards compatibility in pipeline files. Additionally better error reporting should be implemented to tell the user why the read failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant