Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressButton not defined, because there is no update #61

Open
sebastian-marinescu opened this issue Jan 21, 2019 · 4 comments
Open

ProgressButton not defined, because there is no update #61

sebastian-marinescu opened this issue Jan 21, 2019 · 4 comments

Comments

@sebastian-marinescu
Copy link
Contributor

When just visiting the dashboard on a up-to-date MODX,
I get the following JS-error in the console:

progressButton.js:76 Uncaught TypeError: Cannot read property 'getAttribute' of null
    at ProgressButton._validate (progressButton.js:76)
    at ProgressButton._init (progressButton.js:67)
    at new ProgressButton (progressButton.js:57)
    at ugm-bottom.js:43

The JS is right, there is no Button:
image

@BobRay
Copy link
Owner

BobRay commented Jan 21, 2019

Thanks for reminding me. I've seen that. It's harmless, but should be fixed. I'm thinking of just putting the same button in the "up-to-date" message but disabled and with display:none, but haven't had time to try it.

@sebastian-marinescu
Copy link
Contributor Author

Hi Bob, yeah it is harmless, but I (and probably all others, including you) don't like JS errors in the console :)

Why not adapt the JS and not even initialize the button, if it's not there?

@BobRay
Copy link
Owner

BobRay commented Jan 22, 2019

I agree completely and intend to fix it. It's just that I'm in the middle of about six projects right now, some of which are not running at all. ;)

@sebastian-marinescu
Copy link
Contributor Author

Okay, thanks for the info :)
I'll see if I can soon-ish take care of this myself 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants