Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpgradeMODX 2.3.1 and MODX 2.8.3 #74

Open
Jako opened this issue Apr 14, 2022 · 3 comments
Open

UpgradeMODX 2.3.1 and MODX 2.8.3 #74

Jako opened this issue Apr 14, 2022 · 3 comments

Comments

@Jako
Copy link
Contributor

Jako commented Apr 14, 2022 •
edited
Loading

The current version of UpgradeMODX shows the following widget in the frontend:

Screenshot

Version 3 is disallowed, this is fine. But the widget shows the begin upgrade button, even if there is no further version in the 2.x branch.
@BobRay
Copy link
Owner

BobRay commented Apr 14, 2022

Good point, but I'm not sure how to handle this situation. You've always been able to "upgade" to the version you already have, so this just makes it easier. On the other hand, it's not a real upgrade. And should "Upgrade Available" and "Latest Version" 3.0.0-pl" be showing with ugm_show_modx3 off or not? Suggestions welcome.

@Camo30
Copy link

Camo30 commented May 11, 2022

In my opinion "Upgrade Available" and "Latest Version: 3.0.0-pl" should not be shown when ugm_show_modx3 is disabled.

@BobRay
Copy link
Owner

BobRay commented May 11, 2022

I agree, but it may be difficult given the way that the current version is identified. I'll try to find time to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jako @BobRay @Camo30