Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexicon omission #86

Open
SnowCreative opened this issue Dec 24, 2024 · 3 comments
Open

Lexicon omission #86

SnowCreative opened this issue Dec 24, 2024 · 3 comments

Comments

@SnowCreative
Copy link

Very small issue here. I noticed that the French lexicon is missing one entry for the series of messages that appear when you click the Install button to upgrade. The button says "Démarrage de mise à jour" to start it off, but the second message, "Downloading files", is still in English. The rest of the messages that appear in the button are in French.

@BobRay
Copy link
Owner

BobRay commented Dec 25, 2024

Thanks for the report. What it your preferred French version of that message? My French is pretty much limited to ordering in restaurants, and asking for directions, and Google translate is not perfect. ;)

@SnowCreative
Copy link
Author

Is the lexicon consulted during that one step in the button text sequence? I see you do have "Téléchargment des fichiers" for the setting "ugm_downloading_files".

@BobRay
Copy link
Owner

BobRay commented Dec 26, 2024

I thought this would be an easy fix, but it's not. The processors all return the correct language string for the on-screen message describing what happens next (kind of a stupid design, but it avoided having to handle lexicon strings in the JS itself, and also avoided having to load the entire lexicon file). Unfortunately, the download processor is the first one, so it has no return value to use. The English string "Downloading Files" is hard-coded into the JS. I'll try to find time to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants