Rc/1.0.4 #4
Merged
Rc/1.0.4 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameter-with-api-conventions 2 align basic info parameter with api conventions
iglauss
reviewed
Sep 2, 2024
NEWS.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # dv.clinlines 1.0.4 | |||
|
|
|||
| * Adapt basic_info parameter to adhere module standard | |||
There was a problem hiding this comment.
Suggested change
| * Adapt basic_info parameter to adhere module standard | |
| * To comply with the DaVinci module standards, the list entries expected by the `basic_info` module argument were updated as follows: `subject_level_dataset_name` instead of `data`, `trt_start_var` instead of `trt_start`, `trt_end_var` instead of `trt_end`, and `icf_date_var` instead of `icf_date`. |
Adapt mocks to new API
Simplify click interaction. Tweak test to pass locally.
iglauss
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical checks
Is the version number correct?
DESCRIPTION file
NEWS.md
Does the build pass?
Documentation
Does it include the following sections?
Module introduction with features
Installation details
Explanation of function arguments
Data specifications and requirements
Different possible visualizations
Are the changes/new features included in NEWS.md?
(O) Screenshots
(O) Explanation of input menus
(O) Short articles on building the app, compatibility with other modules, known bugs,...
QC Report
API conventions