Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide raw data in non-reactive form as part of afmm #30

Closed
ml-ebs-ext opened this issue Nov 15, 2024 · 0 comments
Closed

Provide raw data in non-reactive form as part of afmm #30

ml-ebs-ext opened this issue Nov 15, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ml-ebs-ext
Copy link
Contributor

ml-ebs-ext commented Nov 15, 2024

According to the "Arguments from Module Manager" vignette, afmm provides, among others: unfiltered_dataset and filtered_dataset. Those are only resolvable in reactive time.
Some modules could benefit from being able to inspect the full suite of datasets provided to the application at start time. That would allow them to:

  • Detect app creation mistakes.
  • Pre-compute UIs for all possible dataset selection.
  • ...

The proposal is to introduce a new afmm member offering that information. Maybe it could be named just "data" and be mostly a pass-through of the dv.manager::run_app() data argument. "Mostly" because run_app allows to provide functions instead of datasets and those would need to be evaluated first.

@ml-ebs-ext ml-ebs-ext added the enhancement New feature or request label Nov 15, 2024
@ml-ebs-ext ml-ebs-ext self-assigned this Nov 22, 2024
This was referenced Nov 22, 2024
@zsigmas zsigmas closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants