This repository has been archived by the owner on Nov 28, 2024. It is now read-only.
Fix compile errors on wasm #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't run on wasm due to wasm-bindgen and miniquad being (currently) incompatible, but if it fixes compilation then it's better than what we have now! Long term goal is to figure out how to get miniquad wasm and wasm-bindgen to play nice so that we can use Kira on wasm. |
|
Also the instructions to get wasm working are on https://github.com/not-fl3/miniquad#wasm |
Bombfuse
added a commit
that referenced
this pull request
Jul 10, 2021
* Remove screen scalar render setting, should not assume stretching * Update dependencies * Update miniquad version * Fix quad-snd branch * Fix 2d texture rendering on multiple GPUs by adding magic number * Update dependencies, add Discord badge * Update github build action * Fix byte loading error message, fix label offets * Replace quad-snd backend with Kira * Associate file paths with sound ids, in order to not re-load a sound every time it's played in a mixer * Add aseprite.get_anim_length, update mixer settings * Try out miniquad github workflow * Add sdl2dev lib to ubuntu workflow * Downgrade fontdue to 0.4.0 * Implement Kira and Dummy audio backends * Remove log, use no-std version of glam * Try out glam 0.14.0 for android build * Update physics example * Add gamepad api for specific index * Prune stopped instances from mixers post update * Implement asset loading on android and adjust README (#56) looks good, thanks for the PR! * Remove unused code * Update github actions, remove wasm compiling for now * Fix actions * Attempt to fix android action * fix actions yaml * Only run actions on PR * Using fl3's container, shouldn't need to install cargo-apk * update android apk command * Mouse input (#59) * Fix compile errors on wasm (#60) * Update all dependencies except fontdue, because that would require some (#61) core logic changes Co-authored-by: Ilia Konnov <[email protected]>
Bombfuse
added a commit
that referenced
this pull request
Jul 10, 2021
* Remove screen scalar render setting, should not assume stretching * Update dependencies * Update miniquad version * Fix quad-snd branch * Fix 2d texture rendering on multiple GPUs by adding magic number * Update dependencies, add Discord badge * Update github build action * Fix byte loading error message, fix label offets * Replace quad-snd backend with Kira * Associate file paths with sound ids, in order to not re-load a sound every time it's played in a mixer * Add aseprite.get_anim_length, update mixer settings * Try out miniquad github workflow * Add sdl2dev lib to ubuntu workflow * Downgrade fontdue to 0.4.0 * Implement Kira and Dummy audio backends * Remove log, use no-std version of glam * Try out glam 0.14.0 for android build * Update physics example * Add gamepad api for specific index * Prune stopped instances from mixers post update * Implement asset loading on android and adjust README (#56) looks good, thanks for the PR! * Remove unused code * Update github actions, remove wasm compiling for now * Fix actions * Attempt to fix android action * fix actions yaml * Only run actions on PR * Using fl3's container, shouldn't need to install cargo-apk * update android apk command * Mouse input (#59) * Fix compile errors on wasm (#60) * Update all dependencies except fontdue, because that would require some (#61) core logic changes Co-authored-by: Ilia Konnov <[email protected]> Co-authored-by: Ilia Konnov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MP3 is disabled because
kira v0.5.3usesminimp3 v0.5.1for decoding, but it depends onslice-deque v0.3.0that has following issue: gnzlbg/slice_deque#86Still not figured out how to run compiled wasm, but at least it compiles.