Adjust JS computations #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlx
commented
Jun 10, 2022
| @@ -185,14 +185,16 @@ export const placeOrder = async ( | |||
|
|
|||
| const priceFp32 = computeFp32Price(market, limitPrice); | |||
|
|
|||
| const formattedLimitPrice = | |||
There was a problem hiding this comment.
Previously had issue with BN being zero when market.baseDecimals > market.quoteDecimals.
| @@ -129,8 +138,13 @@ export class Market { | |||
| this._orderbookAddress = orderbookAddress; | |||
| this._baseSplTokenMultiplier = new BN(10).pow(new BN(baseDecimals)); | |||
| this._quoteSplTokenMultiplier = new BN(10).pow(new BN(quoteDecimals)); | |||
| this._tickSize = orderbookState.tickSize.toNumber(); | |||
| this._minOrderSize = marketState.minBaseOrderSize.toNumber(); | |||
| this._tickSize = roundUiAmount( | |||
There was a problem hiding this comment.
Changed tickSize and minOrderSize to uiAmounts for backwards compatibility with v3.
Adding 'BN' options.
| }; | ||
|
|
||
| export const roundUiAmount = (uiAmount: number) => | ||
| Number(uiAmount.toPrecision(5)); |
There was a problem hiding this comment.
This is needed as the 2 ^ 32 division leaves weird rounding artifacts 5+ decimals out.
|
|
||
| const scalingExponent = market.quoteDecimals - market.baseDecimals; | ||
|
|
||
| return scalingExponent >= 0 |
There was a problem hiding this comment.
Needed for cases where market.baseDecimals > market.quoteDecimals, to prevent BN from rounding down to 0.
|
Can you resolve the conflicts please? |
|
Closing as no longer relevant with AOB v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77