Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'StandardBountiesFactory' to 'StandardBountyFactory' #58

Open
lightclient opened this issue Dec 2, 2018 · 0 comments
Open

Rename 'StandardBountiesFactory' to 'StandardBountyFactory' #58

lightclient opened this issue Dec 2, 2018 · 0 comments

Comments

@lightclient
Copy link
Contributor

lightclient commented Dec 2, 2018 •
edited
Loading

Factory methods should describe what they are making in singular form. Since a singular bounty is created at a time, the factory should be StandardBountyFactory.sol.

I'd also like to drop the "Standard" prefix from both contracts, because it is is a bit redundant since it is the standard bounties repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lightclient