Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GPUImage compatible with Catalyst #300

Open
sabiland opened this issue Jun 6, 2019 · 7 comments
Open

Make GPUImage compatible with Catalyst #300

sabiland opened this issue Jun 6, 2019 · 7 comments

Comments

@sabiland
Copy link

sabiland commented Jun 6, 2019

When macOS 10.15 will be released, I'll port some of my apps to macOS.
Brad do you know maybe if iOS-GPUImage2 is compatible with this?

@BradLarson
Copy link
Owner

GPUImage2 works across Mac and iOS, so all you should need to do is switch the framework target being used from the iOS one to the Mac one. I'm adding Swift Package Manager support (should be operational now, but I need more testing on this), which should aid the process.

@ggua5470
Copy link

ggua5470 commented Jun 8, 2019

How about Swift Package Manager support for GPUImage3 ^_^ ??

@sabiland
Copy link
Author

sabiland commented Jun 8, 2019

Brad I meant this new macOS 10.15 (Xcode 11) feature:

Project Catalyst

What is Project Catalyst?
We'll start off with perhaps the most exciting piece of news for Mac users (and even more exciting for developers). Apple will be making it easier for developers to port iOS apps to the Mac. This is good for developers as they won't need to spend time and money writing code for two different apps.

If maybe you know if porting to macOS via Xcode 11 (macOS checkbox) && GPUImage2 iOS would work? Apple said Xcode 11 will automatically check/decide which third-party libraries will work on macOS port.

@BradLarson
Copy link
Owner

@sabiland - I thought this would be compatible with Catalyst as-is, but looking into it a little more, now I'm not so sure. I'm going to build a Catalyst test case and make sure this works with it.

@ggua5470 - Yes, as soon as I get this working correctly across the three platforms here, I'll bring across pretty much the same Package Manager manifest to GPUImage 3 (without Linux support, of course).

@BradLarson BradLarson reopened this Jun 8, 2019
@BradLarson BradLarson changed the title Is iOS-GPUImage2 compatible for porting iPad apps to macOS 10.15? Make GPUImage compatible with Catalyst Jun 8, 2019
@sabiland
Copy link
Author

@BradLarson thx for info!

@sabiland
Copy link
Author

sabiland commented Oct 4, 2019

I do not know if it is possible for now, but I tried to build my app also for macos Catalina (without modyfying project, just trying to build) and I get those GPUImage2 errors.

Errors

Has anyone maybe succeded to build also for macos Catalina?

EDIT: I have switched to GPUImage3.

@tianye2856
Copy link

I do not know if it is possible for now, but I tried to build my app also for macos Catalina (without modyfying project, just trying to build) and I get those GPUImage2 errors.

Errors

Has anyone maybe succeded to build also for macos Catalina?

EDIT: I have switched to GPUImage3.
@sabiland Have you tried GPUImage3 on Mac Catalyst?
I have rewrite OpenGL shader to GPUImage3 metal shader, it works well on iOS, but the UIImage result on Mac Catalyst is totally empty.
Could you please help me?
Thanks in advance.

@objc public func testAdjustmentGroup() -> UIImage
    {
        let testImage = UIImage(named:"WID-small.jpg")!
        let brightnessFilter = BrightnessAdjustment()   
        let filteredImage = testImage.filterWithOperation(brightnessFilter)
        
        // image is blank, but is not nil
        return filteredImage
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants