Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update documentation #89

Open
Maartenb111 opened this issue Mar 14, 2023 · 6 comments
Open

Please update documentation #89

Maartenb111 opened this issue Mar 14, 2023 · 6 comments
Labels
bug Something isn't working needs-triage

Comments

@Maartenb111
Copy link

Describe the bug

Please update documentation at https://help.branch.io/developers-hub/docs/capacitor (and keep version history of it). For example, Android Branch SDK dependency type changed from implementation to api.

P.s. tried to report this as a documentation issue but the button 'Suggest edits' is not on the documentation page :-/

Steps to reproduce

None

Expected behavior

None

SDK Version

5

Make and Model

None

OS

None

Additional Information/Context

No response

@Maartenb111 Maartenb111 added bug Something isn't working needs-triage labels Mar 14, 2023
@Sampath-Lokuge
Copy link

Did they update the docs now?

@Saqib92
Copy link

Saqib92 commented Apr 14, 2023

any update?

@GiannisS
Copy link

GiannisS commented Jul 19, 2023

Documentation suggests that it got "Updated 5 days ago" but it's definitely incomplete. For example here https://help.branch.io/developers-hub/docs/capacitor#android it suggests that we should update build.gradle with these dependencies

apply plugin: 'com.android.application'

android {
    defaultConfig {
        // ...
+       multiDexEnabled true
        // ...
    }
}

dependencies {
+    implementation("com.google.android.gms:play-services-ads-identifier:18.0.1") // AAID
}

but if you try to build your app in android studio with just these dependencies you are getting errors. The correct documentation should also mention we have to add all these

    implementation 'com.google.android.gms:play-services-ads-identifier:18.0.1'
    implementation 'androidx.multidex:multidex:2.0.1'
    implementation 'com.google.firebase:firebase-appindexing:19.1.0'
    implementation 'androidx.browser:browser:1.2.0'
    implementation 'io.branch.sdk.android:library:5.0.15'

@viking2917
Copy link

@GiannisS Thank you for this! In my case, I am on Capacitor 6, and I only had to add:

    implementation 'com.google.android.gms:play-services-ads-identifier:18.0.1'
    implementation 'androidx.multidex:multidex:2.0.1'

do you know whether the firebase-appindexing, browser, and sdk.android:library are still required?

@viking2917
Copy link

also, I did a 'Suggest Edits' on the Branch documentation page, maybe they will take it :)

@GiannisS
Copy link

@GiannisS Thank you for this! In my case, I am on Capacitor 6, and I only had to add:

    implementation 'com.google.android.gms:play-services-ads-identifier:18.0.1'
    implementation 'androidx.multidex:multidex:2.0.1'

do you know whether the firebase-appindexing, browser, and sdk.android:library are still required?

sorry I haven't worked on the plugin for the last month so I am not sure about the firebase-appindexing, browser, and sdk.android:library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage
Projects
None yet
Development

No branches or pull requests

5 participants