From 15c30fa078d6ce7011a30b25c6899238c491e1d4 Mon Sep 17 00:00:00 2001 From: Brice Redmond Date: Thu, 7 Nov 2024 15:51:06 -0800 Subject: [PATCH] [patch] use version numbers in websdk local build (#1086) # Pull Request Template ## Description I put these to 0.0.0 because i thought it would make it more clear that these come from elsewhere. (we fill these in with the actual gha version when we release). However, some of our apis check the values that we send here. So, having 0.0.0 was breaking some journeys. I put it to 2.85.1. It wont need to be updated unless we make another check on the backend that we want to test Fixes # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [ ] Unit test - [ ] Integration test ## JS Budget Check Please mention the size in kb before abd after this PR | Files | Before | After | | ----------- | ----------- | ----------- | | dist/build.js. | | | | dist/build.min.js| | | ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules - [ ] I have checked my code and corrected any misspellings ## Mentions: List the person or team responsible for reviewing proposed changes. cc @BranchMetrics/saas-sdk-devs for visibility. --- src/0_config.js | 2 +- test/web-config.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/0_config.js b/src/0_config.js index 2ebaec16..70262e48 100644 --- a/src/0_config.js +++ b/src/0_config.js @@ -8,4 +8,4 @@ var DEFAULT_API_ENDPOINT = 'https://api2.branch.io'; config.app_service_endpoint = 'https://app.link'; config.link_service_endpoint = 'https://bnc.lt'; config.api_endpoint = DEFAULT_API_ENDPOINT; -config.version = '0.0.0'; +config.version = '2.85.1'; // will get overwritten by gha on actual deploy diff --git a/test/web-config.js b/test/web-config.js index 152048c4..9636fd6c 100644 --- a/test/web-config.js +++ b/test/web-config.js @@ -6,4 +6,4 @@ goog.provide('config'); config.app_service_endpoint = 'https://app.link'; config.link_service_endpoint = 'https://bnc.lt'; config.api_endpoint = 'https://api.branch.io'; -config.version = '0.0.0'; +config.version = '2.85.1'; // will get overwritten by gha on actual deploy