Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are no examples for Xamarin Forms and documentation is OUT OF DATE. #130

Open
Nerves82 opened this issue Aug 21, 2020 · 2 comments
Open

Comments

@Nerves82
Copy link

Xamarin Forms documentation needs to be improved!! It is woefully out of date and inaccurate.

The documentation provides a link for a xamarin forms implementation but when clicking it one is taken to a xamarin native implementation.

https://github.com/BranchMetrics/xamarin-branch-deep-linking-attribution/tree/master/Branch-Xamarin-Testbed.iOS

https://github.com/BranchMetrics/xamarin-branch-deep-linking-attribution/tree/master/Examples/ios_example

Neither of theses are Xamarin Forms apps.

In the documentation for using Xamarin Forms we are told to have 2 classes that both inherit from "Application", one that implements IBranchSessionInterface and one that implements IBranchBUOSessionInterface. I have found that it is the iOS AppDelegate that has to implement IBranchSessionInterface and NOT the Forms "Application" class since the call to Init the service requires an instance of the IBranchSessionInterface passes as "this".

BranchIOS.Init("key_live_XxxXXXXX", options, this); <-- "this" is IBranchSessionInterface

The docs say "Change the C# project's profile to PCL 4.5 - Profile78". Xamarin Forms is beyond PLCs now that it is .NET standard compatible.

Can you fix the Xamarin Forms documentation to be correct and up to date?
Can we get a up to date Xamarin Forms sample project?

@Nerves82 Nerves82 changed the title There are no examples for Xamarin Forms. There are no examples for Xamarin Forms and documentation is OUT OF DATE. Aug 21, 2020
@ScarletKuro
Copy link

Totally agree, the documentation is absolutely disgusting. Not even saying that it has code mistakes
Img

@echo-branch
Copy link
Contributor

Really sorry about the docs situation. We've lost our regularly Xamarin maintainer and have not backfilled the position yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants