Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all the shows are retrieved / Support special episodes #6

Open
SteelViewer opened this issue Sep 10, 2020 · 10 comments
Open

Not all the shows are retrieved / Support special episodes #6

SteelViewer opened this issue Sep 10, 2020 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@SteelViewer
Copy link

Consider the source code of the page https://dmax.de/sendungen/steel-buddies/
The dmax.py script retrieves all shows for
playertype="showPlayer"
showid="6023"

However there are more shows on the same page that are referenced by the following lines
playertype="collectionPlayer"
collectionid="steel-buddies-special-playlist"
Logically these shows won't be in the xlsx file.

Is it possible to include these too?

Cheers,

@Brawl345
Copy link
Owner

The specials on the Steel Buddies page are just regular episodes that are retrived normally through the script. See this pic for example:

Unbenannt

The first listed special is just a regular episode from season 6. I don't know if there are any other shows with specials that behave differently. Please correct me if I'm wrong.

@Brawl345 Brawl345 added the needs-more-info Needs more information for fixing label Sep 12, 2020
@SteelViewer
Copy link
Author

You're right, most of the Specials are in fact also regular episodes.
I found two that are not part of a season, namely "Sonderschicht XXL:Teil 1" and "Sonderschicht XXL:Teil 2". They describe it as S1:F1 and S1:F2 but in fact that's not the case.
image

BTW, thanks a lot for this great script, it's 99% perfect.

@Brawl345 Brawl345 added enhancement New feature or request and removed needs-more-info Needs more information for fixing labels Sep 13, 2020
@Brawl345 Brawl345 self-assigned this Sep 13, 2020
@Brawl345 Brawl345 changed the title Not all the shows are retrieved Not all the shows are retrieved / Support special episodes Sep 13, 2020
@Brawl345
Copy link
Owner

Thanks, I'll look into it! In the meantime, a friend of mine wrote down the ID as "13466" for the XXL specials.

@SteelViewer
Copy link
Author

Great, works fine for the XXL Specials.
Thanks again for this marvellous script.

@Brawl345
Copy link
Owner

No prob, I looked into it but didn't found a good way to do it... It has a collectionId in the source code, but you have to contact another URL and it's incompatible with the class I wrote so I think this requires more work.

@SteelViewer
Copy link
Author

Sorry to bother you again with this anoying variance. I see today that there are plenty of small videos called "clips" that are referenced by a collectionId (collectionid="steel-buddies-clips").
image
I understand that it's probably a lot of work to implement this case, I just want to pass the information along.
Cheers,

@dennis-th
Copy link

For everyone who is looking for Unboxing 2: Michael packt aus!: ShowId is 16837
And thanks for the script!

@Brawl345
Copy link
Owner

Brawl345 commented Jan 5, 2021

Here is a list of all currently available IDs:

@Akamaru
Copy link

Akamaru commented Apr 21, 2021

If someone is interested, I created a gist with all working ids for dmax, hgtv and tlcde. It will be updated once a week
https://gist.github.com/Akamaru/3646c47b68cccead419716f3c4a7e86e

@SteelViewer
Copy link
Author

Excellent initiative. That makes things much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants