Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS Window Positioning #324

Open
k-hell opened this issue Jul 11, 2024 · 6 comments · May be fixed by Azilroka/AddOnSkins#245
Open

ECS Window Positioning #324

k-hell opened this issue Jul 11, 2024 · 6 comments · May be fixed by Azilroka/AddOnSkins#245
Labels
bug Something isn't working

Comments

@k-hell
Copy link

k-hell commented Jul 11, 2024

Bug description

Tried to make window width bigger but it moves into the character frame

Screenshots

image

Version

v3.3.4
Classic Era

Code

On line 103 in Modules/Stats.lua, I did a "small hack", tried to do it elsewhere but nothing would work so this was my solution...
I'm sure these values could be better or figure out why it grows inside instead of out, would be a good start...
Funny thing is with this "hack", it grows out?

if ECS.IsSoD then
            C_Timer.After(0.3, function ()
                if EngravingFrame then
                    mainFrame:ClearAllPoints()
                    mainFrame:SetPoint("LEFT", EngravingFrame, "RIGHT", 10, 19)
                end
            end)
        else -- the hack
            C_Timer.After(0.3, function ()
                if PaperDollItemsFrame then
                    local __x = 2
                    local __y = 2
                    mainFrame:ClearAllPoints()
                    mainFrame:SetPoint("LEFT", PaperDollItemsFrame, "RIGHT", ecs.general.window.xOffset + __x, ecs.general.window.yOffset + __y)
                end
            end)
        end
    end)
@k-hell k-hell added the bug Something isn't working label Jul 11, 2024
@BreakBB
Copy link
Owner

BreakBB commented Dec 23, 2024

Hey @k-hell

Sorry for not answering on this any earlier. It looks like it is an issue with ElvUI, not sure which (I am not using ElvUI).

Can you grab the latest version and see if the issue still exists?

@k-hell
Copy link
Author

k-hell commented Dec 30, 2024

Hey, I updated the version and in era/fresh I still have problem with window going inwards, but it seems to be fixed in SoD, I assume what you did in this issue (#332) worked for SoD and could maybe be used for era/fresh aswell?

Window width works well in SoD
image
image

Not so well in era/fresh
image

@BreakBB
Copy link
Owner

BreakBB commented Jan 7, 2025

Hey @k-hell can you explain to me, how you get the ECS to look like an ElvUI frame? I never used ElvUI before and think that your issue is a pure ElvUI conflict.

Looks like this for me:

image

@k-hell
Copy link
Author

k-hell commented Jan 9, 2025

Hey @k-hell can you explain to me, how you get the ECS to look like an ElvUI frame? I never used ElvUI before and think that your issue is a pure ElvUI conflict.

Looks like this for me:

image

Hi, seems to be this AddOnSkins
I use an UI addon package

@k-hell
Copy link
Author

k-hell commented Jan 24, 2025

@BreakBB
Copy link
Owner

BreakBB commented Feb 12, 2025

Hey @k-hell sorry for not coming back to you earlier.

I provided a fix to AddOnSkins as I was able to reproduce the error with it 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants