Testing whether large file IO is really activated in zlib under MacOS

and Windows
BrunoLevy · Feb 9, 2025 · 1122202 · 1122202
1 parent 3e32b5e
commit 1122202
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/lib/geogram/basic/geofile.cpp b/src/lib/geogram/basic/geofile.cpp
@@ -157,6 +157,8 @@ namespace {
 
 #else
 
+    #error "64 bit IO not defined in zlib"
+
 #ifdef GEO_OS_WINDOWS
     typedef GEO::Numeric::int64 ssize_t;
 #endif

diff --git a/src/lib/geogram/third_party/zlib/zconf.h b/src/lib/geogram/third_party/zlib/zconf.h
@@ -8,7 +8,11 @@
 #ifndef ZCONF_H
 #define ZCONF_H
 
-/* [Bruno] enable 64 bits IO on MacOS and Windows */
+/*
+ * [Bruno] enable 64 bits IO (needed on MacOS and Windows that do not
+ * set these defines by default
+ */
+
 #if defined(__APPLE__) || defined(_WIN32) || defined(_WIN64)
 #define _LARGEFILE64_SOURCE
 #define _LFS64_LARGEFILE
-Original file line number
+Diff line change
@@ Expand Up / @@ -157,6 +157,8 @@ namespace { @@
     #else
+        #error "64 bit IO not defined in zlib"
     #ifdef GEO_OS_WINDOWS
         typedef GEO::Numeric::int64 ssize_t;
     #endif
@@ Expand Down @@