Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BunnyCDNStorage->HttpClient needs to implement IDisposable since it inherits from HttpMessageInvoker #22

Open
benrussill opened this issue Mar 17, 2022 · 0 comments
Open

BunnyCDNStorage->HttpClient needs to implement IDisposable since it inherits from HttpMessageInvoker #22

benrussill opened this issue Mar 17, 2022 · 0 comments

Comments

@benrussill
Copy link

BunnyCDNStorage

  • needs to implement IDisposable -> disposable pattern
  • HttpClient inherits IDisposable from HttpMessageInvoker

HttpClient
public class HttpClient : System.Net.Http.HttpMessageInvoker

HttpMessageInvoker
public class HttpMessageInvoker : IDisposable
OhSoooLucky added a commit to OhSoooLucky/BunnyCDN.Net.Storage that referenced this issue Mar 6, 2023
@OhSoooLucky
Refactor BunnyCDNStorage, apply BunnyWay#18 and BunnyWay#22 recommend…
12960f1 
…ations where possible
@OhSoooLucky OhSoooLucky mentioned this issue Mar 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benrussill